CI: Use cargo 1.84 feature to check MSRV #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We could go lower but then we'd be at idna<1.0 and I believe that has some advisories ...
7 tasks
Empty2k12
previously approved these changes
Jan 24, 2025
I assume I thought this was necessary for the readme generation, but turns out the readme looks just fine.
resolver 3 is only supported on Rust 1.84 and up
Empty2k12
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://blog.rust-lang.org/2025/01/09/Rust-1.84.0.html#cargo-considers-rust-versions-for-dependency-version-selection
Our MSRV is currently 1.65, otherwise we cannot find a candidate for the regex-syntax crate which is a transitive dependency.
This PR also updates the version of clippy we use to 1.88, and resolves all warnings introduced in the newer versions.